Encourage logging pattern="" compilation failures #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arai-a does this seem good? |
|
Yeah, this is great :) |
|
@arai-a how do you want to appear in the acknowledgments section? |
|
Thank you @annevk |
Closes #439, where we settled on this as a solution to the potential back-compat problem of more patterns failing to compile now that the "u" flag is specified.
annevk
force-pushed
the
regexp-syntaxerror-warning
branch
from
1ed7da5 to
d2a0cbd
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #439, where we settled on this as a solution to the potential back-compat problem of more patterns failing to compile now that the "u" flag is specified.